Update Product.php #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Shoprunners
commented
Oct 11, 2022
Shoprunners
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Make it possible to create a product via webservice in an empty category |
| Type? | bug fix |
| Category? | WS |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop#14903 |
| Related PRs | |
| How to test? | Follow the instructions in the ussue |
| Possible impacts? | unknown |
TomLorenzi
suggested changes
Feb 15, 2023
| @@ -7087,7 +7087,9 @@ public function setWsPositionInCategory($position) | |||
| // result is indexed by recordset order and not position. positions start at index 1 so we need an empty element | |||
| array_unshift($result, null); | |||
| foreach ($result as &$value) { | |||
| $value = $value['id_product']; | |||
| if($value != null) { | |||
There was a problem hiding this comment.
Just move the array unshift after the foreach would avoid getting for logic in here
Performance improvement of checking valid position by counting the resultset only once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.